search

swissbib / vufind

A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
12 stars 7 forks source link

Spell Suggestions should include all terms in all cases #676

Closed liowalter closed 5 years ago

liowalter commented 5 years ago

Compare

In the latter the spell suggestions run a query for "eisenhower inside". In swissbib, only "eisenhower".

I have the feeling we can come closer to vufind core for this topic (using the renderSpellingSuggestions view helper and maybe get rid of some swissbib specialities like https://github.com/swissbib/vufind/blob/master/module/Swissbib/src/Swissbib/VuFind/Search/Solr/SpellingResults.php ?

guenterh commented 5 years ago

@liowalter Without looking into the details of the code I think it's definitely worth a try to use the VuFind implementation as first step after this we can still decide if we need to / or can make it better

liowalter commented 5 years ago

see also https://github.com/vufind-org/vufind/pull/1391