search

swisscom / cf-statistics-plugin

CloudFoundry CLI plugin for displaying real-time metrics and statistics data
Apache License 2.0
27 stars 3 forks source link

Plugin Min CLI Version #1

Open goehmen opened 9 years ago

goehmen commented 9 years ago

Hi. Thanks for the PR. This plugin is great. I noticed that you mentioned in your readme.MD that 6.10.0 of the CLI is required. I just wanted to let you know that with v6.12.x of the CLI, we added the ability to specify a required min CLI version in plugins so that you can inform your users about the 6.10.0 requirement in an interactive and meaningful way. For reference, see https://www.pivotaltracker.com/story/show/93075664 and https://github.com/cloudfoundry/cli/blob/master/fixtures/plugins/test_1.go#L87

Hope this helps!!!

Greg

JamesClonk commented 9 years ago

Hi Greg,

I just had a look at it, but this means that if I use MinCliVersion, then min. version has to be atleast v6.12.x where MinCliVersion was introduced first, right? As the new rpc call is not backwards compatible obviously.

If I build a plugin with it and use it for example on a cf cli v6.10.x, this is the result otherwise:

$ cf stats
rpc: can't find method CliRpcCmd.IsMinCliVersion

Anyway, I'll probably add it in the near future. Thanks!