missing templates and js files in pip package

swisscom / cleanerversion

CleanerVersion adds a versioning/historizing layer to your relational DB which implements a "Slowly Changing Dimensions Type 2" behavior

Apache License 2.0

136 stars 53 forks source link

missing templates and js files in pip package #89

Closed boydjohnson closed 9 years ago

boydjohnson commented 9 years ago

I updated the Manifest.in file to include the template and static directories that include the datetimefilter.html and add_on.js needed for the changeview.

peterfarrell commented 9 years ago

After this PR, we'll need to have the package re-released on PyPI. Currently, the admin functionality doesn't work due to the missing templates (because I didn't think of adding them to the Manifest file).

boydjohnson commented 9 years ago

The packaging wasn't working, but now it is. The change was adding package_data to setup.py. In this pull request I also have solutions to Lack of Docs on Admin Lack of unicode support History not showing as well as the packaging problem where versions/templates/versions/datetimefilter.html and versions/static/js/addon.js weren't included in the package.

maennel commented 9 years ago

@boydjohnson Thanks for the PR! There was an error, however, in the overridden history_view method. Perhaps it would make sense to work a bit on the test coverage... ;)