swissfintechinnovations / ca-payment

Common APIs for AIS and PIS
https://www.common-api.ch
Apache License 2.0
0 stars 3 forks source link

Adjustment ExchangeRate Account/transactions #63

Closed simonmeyerm closed 8 months ago

simonmeyerm commented 9 months ago

The exchangeRate on the /transactions endpoint in AccountAPI need to be adjusted. The pattern was initially wrongly defined and causes issues on bLink production environment.

The pattern should be changed as followed: Old: [0-9][.][0-9]{1,10} New: ^\d{1,11}$|^(?=\d+[.]\d+$).{3,12}$

With the new pattern we would comply to the definition in the camt.053 schema: image

The definition in camt.053 does not imply how many digits before the decimal point are required, whereas the current pattern on the JSON endpoint does.

svenbiellmann commented 9 months ago

@dkoeni please transfer/implement with version 1.6 of SFTI API.

dkoeni commented 8 months ago

Hello @simonmeyerm

My understanding from the meeting on the camt.053 related changes is that we want the adjustment from one number before the dot to multiple numbers before the dot. Your proposed regex does not implement this exclusively. Could you please clarify if and why this is the case or if the regex needs to be adapted?

svenbiellmann commented 8 months ago

Meeting Notes 2.11.23

Draft release V1.6 will be presented on next meeting 6th December 2023.