search

swissmanu / harmonyhubjs-client

A Node.JS library which allows you to interact with your Logitech Harmony Hub.
https://github.com/swissmanu/harmonyhubjs-client
MIT License
155 stars 42 forks source link

Fix disconnect issue #42

Closed hufftheweevil closed 5 years ago

hufftheweevil commented 6 years ago

Set reconnect to true to keep-alive

There have been a number of threads (including in dependencies) raising an issue where this client stops working a certain period of time after connecting.

The issue stems from the underlying xmppClient client. It will emit an 'offline' event in the case of losing connection. This could be listened for and acted on accordingly. However, there is a simpler solution:

The xmppClient client has a 'reconnect' option during creation. When set to true, it will auto-reconnect when it goes offline, and no further action is needed.

swissmanu commented 6 years ago

thank you for your contribution @hufftheweevil. may i kindly ask you to have a look at the contribution section of the readme and rephrase your commit message accordingly? the automated release build will pick up you change more easily afterwards. again, thank you!

hufftheweevil commented 6 years ago

Was that better @swissmanu? I have to admit I hadn't heard of "proper commit messages" until now.

swissmanu commented 6 years ago

i dont see anything changed? did you push?

having a specific format in commit messages helps me to lower the amount of work necessary to release new versions of my libraries. so "proper" is totally depending on the situation :)

hufftheweevil commented 6 years ago

Hmm, I must be a little lost then. I thought you meant the opening message to this thread. Where do I go to do this 'commit message'? I don't see how I can edit the comment on my commit itself.

freaktechnik commented 6 years ago

@hufftheweevil see https://stackoverflow.com/questions/179123/how-to-modify-existing-unpushed-commits#179147 - this also applies to pushed commits, as explained in the answer.

hufftheweevil commented 6 years ago

What a shame that GitHub doesn't have that functionality built in. Not all of us work with the git command line interface. I've done my best at figuring out how to amend the commit message. I was only able to figure out the one-line version, not the multi-line version, so hopefully that meets your standards.

AirBorne04 commented 5 years ago

since this repo seems to be abandoned i created an updated package which includes some of the here available pull requests, hop over to @harmonyhub and give it a try.

swissmanu commented 5 years ago

thanks for your change. it will be included in the next version.