Closed patters closed 5 years ago
This fixes #34. I've been running it for a few weeks and haven't had any problems; previously, Homebridge would crash daily because of this issue.
Hi @patters, I've been trying to resolve this on my own too and I have some questions regarding your implementation:
reconnect: true
? isn't that the user's responsibility to implement his own reconnection policy upon error (e.g throttling)
1.1. If already using reconnect
, why is it omitted from loginWithIdentity
?loginWithIdentity
, where the client might receive errors not related to function but to the consumer (remember the xmppClient
is being passed to the consumer for the session.)since this repo seems to be abandoned i created an updated package which includes some of the here available pull requests, hop over to @harmonyhub and give it a try.
Hi all, I tried to put the fix manually, will keep this thread update dif it is good for me . By the way, any possibility to update the package and homebridge-harmonyhub on npm also in order to have this directly through homebridge ?
Hi,
So @patters fix didn't worked for me : homebridge was not crashed, but harmony plugin was not responding until I restarted homebridge server. I put @kobin fix in place, let's see tomorrow :)
thank you for your change. it will be part of the next released version.