search

swissmanu / harmonyhubjs-discover

A Node.JS library which lookups available Logitech Harmony hubs in the local network.
MIT License
23 stars 9 forks source link

Allow options to be passed into Ping #8

Closed stblassitude closed 6 years ago

stblassitude commented 6 years ago

This allows users to specify the broadcast address to send the ping to. This is neccessary on systems with more than one interface, or certain operating systems.

This allows KraigM/homebridge-harmonyhub#105 to be addressed.

stblassitude commented 6 years ago

Can I use Commitizen to rework this PR? Or do I need to close this and redo the commits on a fresh branch, and submit a fresh PR?

swissmanu commented 6 years ago

i dont have any problem if you force-push your rebased changes to this PR ☺️

stblassitude commented 6 years ago

Let me know if this is acceptable, or needs further refinement.

swissmanu commented 6 years ago

perfect, thanks for reworking :) will release a new version asap

swissmanu commented 6 years ago

latest release v1.1.1 is available with your changes 🙌

stblassitude commented 6 years ago

Thank you!