Closed gfellerph closed 1 year ago
Latest commit: 0cde4d3f71d2bfee9917aa41fce3a1dcb4edaa89
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/
🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/
@swisspost/design, this PR can be reviewed again at https://preview-103--swisspost-web-frontend.netlify.app/#/bootstrap-samples/buttons. Thx for reviewing.
🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/
🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/
@alizedebray, thanks for the review! The color of hovered buttons should stay opaque for accessibility (https://github.com/swisspost/common-web-frontend/pull/103#pullrequestreview-1013223650) and the disabled button styles were improved to be as contrastful as possible (primary on light bg is not accessible).
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.5% Duplication
This change updates button dimensions according to the design and reduces the file size of the button.css to ~7kb uncompressed because the arrow icon is now made with CSS and can make use of currentColor instead of a background icon which had to be "colored" by inversion.