swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

fix(button): update button sizes #103

Closed gfellerph closed 1 year ago

gfellerph commented 1 year ago

This change updates button dimensions according to the design and reduces the file size of the button.css to ~7kb uncompressed because the arrow icon is now made with CSS and can make use of currentColor instead of a background icon which had to be "colored" by inversion.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 0cde4d3f71d2bfee9917aa41fce3a1dcb4edaa89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | --------------------- | ----- | | @swisspost/web-demo | Patch | | @swisspost/web-styles | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/

gfellerph commented 1 year ago

@swisspost/design https://preview-103--swisspost-web-frontend.netlify.app/#/bootstrap-samples/buttons

gfellerph commented 1 year ago
github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/

gfellerph commented 1 year ago

@swisspost/design, this PR can be reviewed again at https://preview-103--swisspost-web-frontend.netlify.app/#/bootstrap-samples/buttons. Thx for reviewing.

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-103--swisspost-web-frontend.netlify.app/

gfellerph commented 1 year ago

@alizedebray, thanks for the review! The color of hovered buttons should stay opaque for accessibility (https://github.com/swisspost/common-web-frontend/pull/103#pullrequestreview-1013223650) and the disabled button styles were improved to be as contrastful as possible (primary on light bg is not accessible).

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication