search

swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

feat(components): add alert component #1085

Closed alizedebray closed 7 months ago

alizedebray commented 1 year ago

@oliverschuerch @gfellerph I opened this PR as a draft so that we can discuss the following points:

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 227a51174df821d3b12fa50f2c45b40a6a8a13ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | ------------------------------------------- | ----- | | @swisspost/design-system-styles | Patch | | @swisspost/design-system-documentation | Minor | | @swisspost/design-system-components | Minor | | @swisspost/design-system-components-angular | Patch | | @swisspost/design-system-demo | Patch | | @swisspost/internet-header | Patch | | @swisspost/design-system-intranet-header | Patch | | @swisspost/design-system-components-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot commented 1 year ago

Preview environment ready: https://preview-1085--swisspost-design-system-next.netlify.app Preview environment ready: https://preview-1085--swisspost-web-frontend.netlify.app

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

alizedebray commented 9 months ago

@oliverschuerch @gfellerph I opened this PR as a draft so that we can discuss the following points:

* **Main question:** Should we merge the new post-alert story with the existing alert story? If so, how?
  With the development of the web component library we will often face this question in the future, thus now is a good time to choose a documentation architecture that takes this duality into account.

* **Subsidiary question:** The post-alert documentation currently uses Stencil generated controls. In your opinion, is it good as is or would it be better to customize it?

Main answer: we decided to go with a single docs page and use tabs to show examples for standard HTML and Web Components. This PR is therefore blocked by the tabs PR #1181 image

Subsidiary answer: we decided to use Stencil generated controls and customize them if necessary

alizedebray commented 9 months ago

TODO:

alizedebray commented 7 months ago

Several bugs or questions:

  • Bug on WebC variant, Icon is displayed above text, but main icon does not change.

  • On primary type, when we change the icon, the color is black instead of white. This a bug already present in the current version, but I'm wondering if this will be maybe fixed with the PR's about mask icon?

  • Standard HTML alert is not dismissable (or at least there is no control anymore). It makes sense according to the recommendation that you wrote on the docs, but then it should be deprecated no?

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

alizedebray commented 7 months ago

Ticket to deprecate dismissible HTML alerts: #2014