Optimize Tabs - Githubissues

wueestd commented 1 year ago

wueestd commented 11 months ago

auch hier wäre ich um ein review froh @rouvenpost

wueestd commented 11 months ago

@gfellerph changed the border color and the hover state

gfellerph commented 11 months ago

Approved @wueestd

wueestd commented 11 months ago

wueestd commented 10 months ago

@gfellerph could you please check differences

gfellerph commented 10 months ago

Generic feedback:

[x] Hover and focus states differ a lot in Design. With other components we usually take the hover state and put a black outline around. Proposal for design: hover and focus states for both active and inactive get a yellow background, focus gets a black outline on top
[x] Tab backgrounds don't match, implementation is grey, design is white -> update implementation
[x] Hover state colors don't match -> update implementation
[x] Focus outline in implementation is 1px with no offset, 2px with 2px offset in design (more consistent) -> make design proposals for improvements

Mobile:

[ ] Scroll arrows are not implemented in dev -> implement with new web component

wueestd commented 10 months ago

I agree that the inactive focus must be yellow. in my oppinion such a thing as a active hover doesn't exist since it's not clickable, therefore I just used the same colors as default.

@gfellerph for the other points let's have a short meeting

gfellerph commented 9 months ago

@wueestd closing as completed.

swisspost / design-system