search

swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

fix(switch): adds a border in windows hcm #116

Closed gfellerph closed 1 year ago

gfellerph commented 1 year ago

Introduces a visible border to be able to see the outline of inactive switches in Windows High Contrast Mode.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: babd3cf1f3b8f213b30d59ae4a56cced9a959f4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @swisspost/web-styles | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-116--swisspost-web-frontend.netlify.app/

gfellerph commented 1 year ago

Maybe it's better to redesign the active / checked state of the switch: from this: image to this: image

good idea, maybe even solid yellow (active) background.

rouvenpost commented 1 year ago

Solid yellow active it is. 👍🏻

Holen Sie sich Outlook für iOShttps://aka.ms/o0ukef

Von: Philipp Gfeller @.> Gesendet: Tuesday, June 21, 2022 5:31:48 PM An: swisspost/common-web-frontend @.> Cc: Steiger Rouven, K311 extern @.>; Review requested @.> Betreff: Re: [swisspost/common-web-frontend] fix(switch): adds a border in windows hcm (PR #116)

Maybe it's better to redesign the active / checked state of the switch: from this: [image] https://user-images.githubusercontent.com/16400253/174792482-97fc8d59-dc9b-40cb-bc57-06224c436d5b.png to this: [image] https://user-images.githubusercontent.com/16400253/174793691-d91087ec-de48-4294-8810-7b38ed538439.png

good idea, maybe even solid yellow (active) background.

— Reply to this email directly, view it on GitHubhttps://github.com/swisspost/common-web-frontend/pull/116#issuecomment-1161920242, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY4V4XI36BT6F566FEWKMLTVQHN6JANCNFSM5YX2MAZQ. You are receiving this because your review was requested.Message ID: @.***>

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-116--swisspost-web-frontend.netlify.app/

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-116--swisspost-web-frontend.netlify.app/

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication