swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
121 stars 14 forks source link

Update tab styles #1655

Closed gfellerph closed 1 month ago

gfellerph commented 1 year ago

The tabs component got a design overhaul.

Design: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=70-18&mode=design&t=gh5btDmzaOgNux8c-0

Optimization Ticket: https://github.com/swisspost/design-system/issues/1125

Scope: These styles should only be applied to the tabs web component. The ngb-tabs should stay as they are to ensure backwards compatibility.

### Tasks
- [x] blocked by https://github.com/swisspost/design-system/issues/1654
- [ ] Color variants are no longer supported
- [ ] https://github.com/swisspost/design-system/issues/1938
gfellerph commented 3 months ago

Check if color variation code is removed. If yes, ticket is already done.

gfellerph commented 2 months ago

Tab color variant styles are still present https://github.com/swisspost/design-system/blob/main/packages/styles/src/components/tabs/_tab-title.scss#L115. They can be removed.

gfellerph commented 1 month ago

Closing in favor of a future tab v2 ticket. Breaking changes are no longer being implemented for v1 components.