Component: Search - Githubissues

wueestd commented 8 months ago

FIgma https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=16739%3A53259&mode=design&t=i6IlqbsNcGrr8I6l-1

Dev https://next.design-system.post.ch/?path=/docs/internet-header-header-component--docs

Doc https://www.experience-hub.ch/document/2803#/organisms-module/search-filter

wueestd commented 6 months ago

not yet :)

wueestd commented 6 months ago

could you review the component please @rouvenpost :)

rouvenpost commented 6 months ago

@wueestd The component is approved from my side.

wueestd commented 6 months ago

@kaloyanso / @Cian77 the component is ready for review, thanks :)

wueestd commented 5 months ago

ready for dev review @gfellerph

gfellerph commented 5 months ago

To discuss:

[x] Is a disappearing placeholder icon (the magnifying glass) unique to the search or do other input fields have this feature? -> not really, search is the only one that has x and disappearing icon
[x] Is the clear content button unique to the search input or do other input fields have this feature? (https://github.com/swisspost/design-system/issues/2248)
[x] How exactly does the suggestion list work?
- Does a click on the item start the search or update the value of the input box? -> should stay flexible for any use case, component should not include business logic
- Is the icon variable? -> yes
- How many items are displayed at max? -> 8, everything else will be scrolled, API should not deliver more than 8
- How does the list look like if it's empty? -> hide list
[x] Consider adding the special case of track and trace results

wueestd commented 5 months ago

I have added the example in Figma, can we close this? @gfellerph

gfellerph commented 5 months ago

approved, @wueestd. I'll also create a dev ticket for the autocomplete/suggestionlist component

wueestd commented 5 months ago

published

swisspost / design-system