swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

fix(styles): add focus color on datepicker component #2061

Closed davidritter-dotcom closed 2 weeks ago

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 57efb7d2ce8ae31fdca62b9d61f4f592fe0e3b7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

swisspost-bot commented 7 months ago

Preview environment ready: https://preview-2061--swisspost-web-frontend.netlify.app Preview environment ready: https://preview-2061--swisspost-design-system-next.netlify.app

sonarcloud[bot] commented 5 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gfellerph commented 3 months ago

@davidritter-dotcom implement with the current definition in Figma.

gfellerph commented 1 month ago

@davidritter-dotcom design is ready. This is no longer blocked.

davidritter-dotcom commented 1 month ago

Waiting for #2855 because of the change in the foucs-style mixin.

oliverschuerch commented 1 month ago

@davidritter-dotcom: This task is in progress quite long now. Do you need help with something? Do you need preciser instructions from one of the reviewer (@imagoiq and @gfellerph)?

Let me know if we can help.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

davidritter-dotcom commented 4 weeks ago

The focus on the select itself gets fixed when a decision is reached on how to apply focus styles to form-select and form-control.