swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

feat(internet-header): replaces twitter logo with X logo in footer #2176

Closed b1aserlu closed 6 months ago

b1aserlu commented 6 months ago

@rouvenpost check out the logo in comparison to the other logos in the footer of the internet-header component in the preview. https://preview-2176--swisspost-design-system-next.netlify.app/?path=/docs/internet-header-footer--docs

In my opinnion the logo does not seem to fit in. It would be better if we had a version where the lines of the X are thicker. similar to what they have in bootstrap. https://icons.getbootstrap.com/icons/twitter-x/

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 85fcb68a50f3b2e19b49c8e7766903fe63c250d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------------------------------- | ----- | | @swisspost/internet-header | Minor | | @swisspost/design-system-documentation | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot commented 6 months ago

Preview environment ready: https://preview-2176--swisspost-design-system-next.netlify.app

rouvenpost commented 6 months ago

@b1aserlu thank you for your request. I changed the icon as proposed. it should be in the library with the next sync. Probably this evening.

rouvenpost commented 6 months ago

The new fat X is updated in Figma.

rouvenpost commented 6 months ago

The new Fat X is available in the Library now.

gfellerph commented 6 months ago

@b1aserlu, I updated the icons package https://github.com/swisspost/design-system/pull/2206

sonarcloud[bot] commented 6 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication