Component: Radio Button Card | Positive

swisspost / design-system

The Swiss Post Design System - for a consistent and accessible user experience across the web platform.

https://design-system.post.ch

Apache License 2.0

124 stars 14 forks source link

Closed wueestd closed 8 months ago

wueestd commented 1 year ago

Figma: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=12335%3A38389&mode=design&t=Czazc5TyV7SLqlrt-1

Story Book: https://preview-2260--swisspost-design-system-next.netlify.app/?path=/docs/components-forms-radio-button-card--docs https://preview-2260--swisspost-design-system-next.netlify.app/?path=/docs/886fabcf-148b-4054-a2ec-4869668294fb--docs

Comments:

rouvenpost commented 10 months ago

@Cian77 i prepared the Radio Cards. Can you have a look at it? With special emphasis on the Focus State? Not shure if it is correct.

Cian77 commented 9 months ago

@rouvenpost I have had a look at the component and have following my comments:

I think we should keep to the states as defined: I changed active to selected
From usability perspective, we should decide how to switch between positive and negative, so it's always the same.
By the Checkbox component we added a group, do we want to have this with this component?
I think, the error state will not be accessible as it is now.
Add Link to story book.

rouvenpost commented 9 months ago

@Cian77 i added the Group and the Link and a Do and Dont for the Negative Variant. Is the Error State Needed here? What would be the Usecase here?

rouvenpost commented 9 months ago

i added the Error Message to the Goup Component.

rouvenpost commented 9 months ago

Design is ready for Review

oliverschuerch commented 8 months ago

Looks ok to me. Nice job!