search

swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

feat(demo): provide internationalization guidelines for ng-bootstrap components #2517

Closed alizedebray closed 3 months ago

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 655335d5794dcc652605315a09e44a994c599862

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------------- | ----- | | @swisspost/design-system-demo | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot commented 3 months ago

Preview environment ready: https://preview-2517--swisspost-web-frontend.netlify.app

imagoiq commented 3 months ago

The build fails, let me know when I can review

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

alizedebray commented 3 months ago

The build fails, let me know when I can review

@imagoiq The build in fixed, you can now review the PR.

alizedebray commented 3 months ago

Could you change the demo app so it works with the first example here https://preview-2517--swisspost-web-frontend.netlify.app/#/ng-bootstrap-samples/datepicker ?

@imagoiq Not realy: the translations are injected when the component is created and they cannot be changed afterwards.

The datepicker is created the first time it is opened, which means that if I select a language before it is properly applied. Howerver, it is not destroyed when closed, the same instance is used for all further opening. Therefore, if I change the language again is not applied.