feat(styles): add custom theme for primeng

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: ac2b5cf5b56b65f1b393dbbce111107fe3ccb6e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages

| Name | Type | | ----------------------------------------------------- | ----- | | @swisspost/design-system-styles-primeng | Major | | @swisspost/design-system-styles-primeng-workspace | Major | | @swisspost/design-system-documentation | Minor | | @swisspost/design-system-styles | Patch | | @swisspost/design-system-components-angular-workspace | Patch | | @swisspost/design-system-components | Patch | | @swisspost/design-system-demo | Patch | | @swisspost/internet-header | Patch | | @swisspost/design-system-intranet-header-workspace | Patch | | @swisspost/design-system-nextjs-integration | Patch | | @swisspost/design-system-intranet-header | Patch | | @swisspost/design-system-components-react | Patch | | @swisspost/design-system-components-angular | Patch | | @swisspost/design-system-icons | Patch | | @swisspost/design-system-migrations | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot commented 2 months ago

Preview environment ready: https://preview-2718--swisspost-web-frontend.netlify.app Preview environment ready: https://preview-2718--swisspost-design-system-next.netlify.app

alizedebray commented 2 months ago

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

imagoiq commented 2 months ago

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.

alizedebray commented 2 months ago

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis? The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.