Closed imagoiq closed 1 month ago
Latest commit: 93fbbc5c8dd86f84792770d4dfdb1aac8f791bc2
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Preview environment ready: https://preview-2875--swisspost-design-system-next.netlify.app
@rouvenpost Can you please check all the links and the missing list of components (in the description of this PR), please?
[x] Add link to Card-Button docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=2452-66025&mode=design&t=jADNra0puVcBoQ9V-0
[x] Add link to Breadcrumb docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=21648-20076&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Footer docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=26665-17211&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Header docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=19536-26512&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Intranet-Header docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=28233-57868&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Modal docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=20215-22938&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Notification Overlay docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=22748-36043&mode=design&t=HksCTWa2MMccgMl4-0
[x] Add link to Typeahead docs: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=22981-41449&mode=design&t=HksCTWa2MMccgMl4-0
[ ] Add link to Carousel docs: ?
[ ] Add link to Collapsible docs: ?
[ ] Add link to Subnavigation docs: ?
[ ] Add link to Timepicker docs: ?
The docs with unknown (?) Figma url can be ignored, I've just added them for documentation purposes.
Housten we have a problem:
My suggestion:
* [ ] Shorten the button text from "Figma Design" to "Figma" and the "See archived documentation" to "Archived docs". * [ ] Take into consideration to implement small buttons (`btn-sm`, if easy to do so, add the class only on small devices). * [x] Let content wrap on a new line if there is not enouth space.
Thanks for the research. I fixed the responsiveness. About your suggestions, I think we don't need to shorten the links, just wrap them. I added the word "design" as it might not be clear for someone who doesn't know what Figma is.
I checked all the Links and they work as intended. It would be nice if the Figma Link opens in a new Tab instead of the same Tab...
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
For reviews: