swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

feat(documentation): Add link to figma #2875

Closed imagoiq closed 1 month ago

imagoiq commented 1 month ago

For reviews:

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 93fbbc5c8dd86f84792770d4dfdb1aac8f791bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------------------- | ----- | | @swisspost/design-system-documentation | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot commented 1 month ago

Preview environment ready: https://preview-2875--swisspost-design-system-next.netlify.app

imagoiq commented 1 month ago

@rouvenpost Can you please check all the links and the missing list of components (in the description of this PR), please?

imagoiq commented 1 month ago

The docs with unknown (?) Figma url can be ignored, I've just added them for documentation purposes.

Housten we have a problem: image

My suggestion:

* [ ]  Shorten the button text from "Figma Design" to "Figma" and the "See archived documentation" to "Archived docs".

* [ ]  Take into consideration to implement small buttons (`btn-sm`, if easy to do so, add the class only on small devices).

* [x]  Let content wrap on a new line if there is not enouth space.

Thanks for the research. I fixed the responsiveness. About your suggestions, I think we don't need to shorten the links, just wrap them. I added the word "design" as it might not be clear for someone who doesn't know what Figma is.

rouvenpost commented 1 month ago

I checked all the Links and they work as intended. It would be nice if the Figma Link opens in a new Tab instead of the same Tab...

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud