search

swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
105 stars 13 forks source link

fix(styles): Checkbox checkmark are invisible on dark background #2953

Closed imagoiq closed 2 weeks ago

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: bcd4c31d9104bdd0b1e8fc141e056800972f64e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages | Name | Type | | ----------------------------------------------------- | ----- | | @swisspost/design-system-styles | Patch | | @swisspost/design-system-components-angular-workspace | Patch | | @swisspost/design-system-components | Patch | | @swisspost/design-system-demo | Patch | | @swisspost/design-system-documentation | Patch | | @swisspost/internet-header | Patch | | @swisspost/design-system-intranet-header-workspace | Patch | | @swisspost/design-system-nextjs-integration | Patch | | @swisspost/design-system-intranet-header | Patch | | @swisspost/design-system-components-react | Patch | | @swisspost/design-system-components-angular | Patch | | @swisspost/design-system-icons | Patch | | @swisspost/design-system-migrations | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

imagoiq commented 2 weeks ago

The change come from here: https://github.com/swisspost/design-system/commit/9c40fd7d23d5d4a437fe3923037c93a9e5c353c5 But I don't see any change in the card-control component @oliverschuerch

swisspost-bot commented 2 weeks ago

Preview environment ready: https://preview-2953--swisspost-web-frontend.netlify.app Preview environment ready: https://preview-2953--swisspost-design-system-next.netlify.app

gfellerph commented 2 weeks ago

The change come from here: 9c40fd7 But I don't see any change in the card-control component @oliverschuerch

@imagoiq this line https://github.com/swisspost/design-system/pull/2953/files#diff-c0a3347da70fe4b7be6aa1a19ef1828c327082f825f230e9557dada9e02cee44R185 was also added because of the white background. If it's transparent (or even remove the definition), the line for the switches can be removed as well.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud