[component]: Popover - Githubissues

swisspost / design-system

The Swiss Post Design System - for a consistent and accessible user experience across the web platform.

https://design-system.post.ch

Apache License 2.0

126 stars 14 forks source link

[component]: Popover #3278

Open Cian77 opened 4 months ago

Cian77 commented 4 months ago

Description

Open issues:

Design:

[ ] New font
[ ] Spacing

Tokens:

[x] Text

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=21-173

Tokens

[ ] Tokens for this component are ready

Tasks

### 💻 Tasks
- [ ] Define more generic tokens
- [ ] Update styles with tokens
- [ ] Documentation in Storybook
- [ ] End to end tests
- [ ] Visual regression tests
- [ ] Design review

gfellerph commented 1 month ago

There is an existing PR, but the tokens need re-specification for this component (some of them are way too specific) and the component styles in the existing PR require a re-work.

Vandapanda commented 2 weeks ago

From a programming perspective its just legend, links, body and close button on dark background. Added to pattern discussion as we need to figure out how to implement that one in figma as well

gfellerph commented 2 weeks ago

@Vandapanda content does not need to be tokenised, just padding, border-radius, etc.