swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

feat!: rename everything #355

Closed gfellerph closed 1 year ago

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c2119aadc503238c7c94bbfc78ccb3edc9a5e6ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | ------------------------------------------- | ----- | | @swisspost/design-system-demo | Major | | @swisspost/design-system-styles | Major | | @swisspost/design-system-intranet-header | Major | | @swisspost/design-system-components-angular | Major | | @swisspost/design-system-migrations | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago

🚀 Preview environment ready: https://preview-355--swisspost-web-frontend.netlify.app

oliverschuerch commented 1 year ago

When running the script pnpm start:intranet-header, an error occurs in the File: packages/components-angular/projects/intranet-header-showcase/src/app/app.module.ts line 4

// app.module.ts:4
import { SwissPostIntranetHeaderModule } from 'swisspost-intranet-header';
oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles reset one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1
oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles lint one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 lint: `stylelint src/**/*.scss`
Exit status 2

ℹ️ The script pnpm --filter design-system-styles lint:fix works fine.

oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles storybook one after the other, many error occurs with the same info:

ERROR in ./src/post-basics.scss
Module build failed (from C:/GIT/swisspost/design-system/node_modules/.pnpm/style-loader@3.3.1/node_modules/style-loader/dist/cjs.js):
TypeError: this.getOptions is not a function
    at Object.loader (C:\GIT\swisspost\design-system\node_modules\.pnpm\style-loader@3.3.1\node_modules\style-loader\dist\index.js:19:24)
 @ ./.storybook/preview.js 1:0-33
 @ ./.storybook/preview.js-generated-config-entry.js
 @ multi C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+core-client@6.5.9_5f7f4oajfffdifcutnf2ilgsam/node_modules/@storybook/core-client/dist/esm/globals/polyfills.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+core-client@6.5.9_5f7f4oajfffdifcutnf2ilgsam/node_modules/@storybook/core-client/dist/esm/globals/globals.js C:/GIT/swisspost/design-system/node_modules/.pnpm/webpack-hot-middleware@2.25.1/node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false&noInfo=true ./storybook-init-framework-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+html@6.5.9_@babel+core@7.18.10/node_modules/@storybook/html/dist/esm/client/preview/config-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+html@6.5.9_@babel+core@7.18.10/node_modules/@storybook/html/dist/esm/client/docs/config-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-links@6.5.9/node_modules/@storybook/addon-links/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-docs@6.5.9_@babel+core@7.18.10/node_modules/@storybook/addon-docs/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-actions@6.5.9/node_modules/@storybook/addon-actions/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-backgrounds@6.5.9/node_modules/@storybook/addon-backgrounds/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-measure@6.5.9/node_modules/@storybook/addon-measure/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-outline@6.5.9/node_modules/@storybook/addon-outline/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-interactions@6.5.9/node_modules/@storybook/addon-interactions/preview.js-generated-config-entry.js ./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles build:storybook one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 build:storybook: `build-storybook`
Exit status 1
oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo reset one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1
gfellerph commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo reset one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1

Removed the script as it's broken anyways and not needed anymore.

oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo test one after the other, every single karma-test fails. It is unclear whether this was already the case before the renamings?

gfellerph commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo test one after the other, every single karma-test fails. It is unclear whether this was already the case before the renamings?

Karma tests for all the packages are not set up

oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, some errors occurs:

Jasmine started

  workspace-project App
    Ă— should display welcome message
      - Expected 'Swiss Post' to equal 'Welcome to app!'.

**************************************************
*                    Failures                    *
**************************************************

1) workspace-project App should display welcome message
  - Expected 'Swiss Post' to equal 'Welcome to app!'.

Executed 1 of 1 spec (1 FAILED) in 2 secs.
oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 ng: `ng "e2e"`
Exit status 1
gfellerph commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 ng: `ng "e2e"`
Exit status 1

e2e tests are not set up either

oliverschuerch commented 1 year ago

When running the scripts pnpm bootstrap and pnpm --filter design-system-components-angular clean one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-components-angular@0.0.1-alpha.0 clean: `rimraf dist`
Exit status 1
sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 151 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 106 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication