swisspost / design-system

The Swiss Post Design System pattern library for a consistent and accessible user experience across the web platform.
https://design-system.post.ch
Apache License 2.0
106 stars 13 forks source link

Optimize Select #804

Closed wueestd closed 1 year ago

wueestd commented 1 year ago

https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7802%3A33963&t=zTAKJLbklgpXEsSf-1

wueestd commented 1 year ago

Tasks UX:

gfellerph commented 1 year ago
Size Figma Demo App
72px
54.5px
48px ~ 46.5px
35.5
Cian77 commented 1 year ago
wueestd commented 1 year ago

Ready for second review @gfellerph https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7802%3A33963&t=zTAKJLbklgpXEsSf-1

gfellerph commented 1 year ago

@wueestd Figma looks great, just a question: what are the empty viewports for, next to the component? I updated the status in the component tracker and created separate issues for devs.

wueestd commented 1 year ago
@gfellerph we found out that states for a floating label field are different, depending on the fact if they are filled or not. therfore we changed the variant sctructure to a matrix: empty filled
Default
Hover
Selected
Error
...

Does that help?

wueestd commented 1 year ago

@gfellerph should we close this task?

gfellerph commented 1 year ago

Closing as done. Status is updated and dev tasks are created.