swissspidy / media-experiments

WordPress media experiments
GNU General Public License v2.0
84 stars 1 forks source link

Re-enable webkit tests #602

Closed swissspidy closed 1 month ago

github-actions[bot] commented 1 month ago

Size Change: +4 B (0%)

Total Size: 7.31 MB

ℹ️ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `build/100.js` | 88.7 kB | 0 B | | `build/699.js` | 2.35 MB | 0 B | | `build/ai.worker.js` | 177 kB | 0 B | | `build/blurhash.worker.js` | 3.23 kB | 0 B | | `build/canvas.worker.js` | 2.79 kB | 0 B | | `build/chunk-ffmpeg.js` | 5.92 kB | 0 B | | `build/chunk-selfie-segmentation.js` | 16.3 kB | 0 B | | `build/dominant-color.worker.js` | 4.45 kB | 0 B | | `build/ffmpeg.js` | 1.09 kB | 0 B | | `build/heif.worker.js` | 450 kB | 0 B | | `build/media-experiments-blocks-rtl.css` | 297 B | 0 B | | `build/media-experiments-blocks.css` | 296 B | 0 B | | `build/media-experiments-rtl.css` | 885 B | 0 B | | `build/media-experiments.css` | 885 B | 0 B | | `build/media-experiments.js` | 77.2 kB | 0 B | | `build/pdf.js` | 579 B | 0 B | | `build/subtitles.js` | 850 B | 0 B | | `build/view-upload-request-view-rtl.css` | 716 B | 0 B | | `build/view-upload-request-view.css` | 717 B | 0 B | | `build/view-upload-request.js` | 18 kB | +4 B (+0.02%) | | `build/vips-heif.********.wasm` | 1.27 MB | 0 B | | `build/vips-jxl.********.wasm` | 800 kB | 0 B | | `build/vips.********.wasm` | 2 MB | 0 B | | `build/vips.worker.js` | 37.9 kB | 0 B |

compressed-size-action

swissspidy commented 1 month ago

I think the remaining ones are blocked by #611

kleisauke commented 1 month ago

I haven't been able to reproduce that error on non-x86 based architectures yet. As an experiment, we could try running the E2E WebKit tests on a macos-14 runner to verify if this issue persists.

FWIW, hopefully they prioritize that WebKit bug report, as it can probably be used for fingerprinting (e.g. to distinguish Silicon-based Macs from Intel-based ones).

kleisauke commented 1 month ago

After some thought, perhaps it might be just easier to pass the JSC_webAssemblyLLIntTiersUpToBBQ=0 env variable when running the WebKit tests on Ubuntu? I had a quick go with commit https://github.com/kleisauke/media-experiments/commit/f428a27a433a29d72743d8cfe5242fbbc54fc091, which seems to work at first glance.