Use Translation object instead of plain arrays

[szepeviktor]

return (new Translation())
    ->setRevisonDate('+0000')
    ->setGenerator('WordPress/6.3-alpha-55629')
    ->addSingularMessage('FooBar', 'Bay')
    ->addSingularMessages([
    'Foo' => 'Bar',
    'Bar' => 'Baz',
    ])
    ->addPluralMessages([
    '1 Dragon' => ['1 Dragon', '2 Dragons'],
    ])
;

... then cache its values in the plugin.

From https://github.com/swissspidy/wp-php-translation-files/commit/0a25fc5d61ae6596b4c75294e21f134522e31f4c

[swissspidy]

This will be a great discussion topic 👍

[szepeviktor]

This will be a great discussion topic 👍

Where I run away bravely when it's my turn!

[swissspidy]

Discussion topics (not an exhaustive list):

• Performance
• Static analysis
• Security
• User/Developer friendliness
• Interoperability with other systems (e.g. GlotPress import/export, WP-CLI i18n command)

[szepeviktor]

Performance

Cache its output after the first run.

User/Developer friendliness

Who do you want to be friendly to? A typist of source code or a software developer with engineering qualities? (theoretical question)

[szepeviktor]

(theoretical question)

Not! I wouldn't design something to be arrays just for making it easy for non-experts. So: Pascal software -> 3 500 000 users Viktor software -> 500 users

[swissspidy]

Cache its output after the first run.

Caching would work for either option, and even for the current .mo file loading process. So I kinda want to ignore caching a bit for this discussion :)