swisstopo / topo-satromo

Erdbeobachtungs-Satellitendaten fürs Trockenheitsmonitoring (SATROMO)
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Abort when Cloudmask CS+ it’s not available #80

Closed davidoesch closed 6 months ago

davidoesch commented 7 months ago

Describe the bug In the case of delay of S2 processing at GEE (see https://groups.google.com/g/google-earth-engine-developers/c/y4wUmsNCeSo/m/La3OmjZ4AQAJ) , there is not a complete / missing cs+ available, and the processed cloud probability layer is empty, see e g https://data.geo.admin.ch/browser/index.html#/collections/ch.swisstopo.swisseo_s2-sr_v100/items/2024-04-10t101601

To Reproduce Steps to reproduce the behavior:

  1. Reprocess an orbit where cs+ it’s not yet available (or not complete, which might be difficult to achieve)
  2. Run processor
  3. Generated cloud probability in STAC is empty/ same values

Expected behavior If CS+ is not available, processor is aborted and an entry in https://github.com/swisstopo/topo-satromo/blob/main/tools/step0_empty_assets.csv is made stating: no csplus

Additional context Related to https://github.com/swisstopo/topo-satromo/issues/61

davidoesch commented 7 months ago

@Tschoun vielleicht ein gutes issue um step0 s2 sr zu ergänzen

Tschoun commented 7 months ago

Example: On the 16th of April at 13:50 the CloudScore+ dataset for the S2 overpass on the 15th is not yet complete. image

Tschoun commented 7 months ago

image

Added to both S2_SR and S2_TOA. No processing of the data if cloud probability (either CloudScore+ or S2 cloud probability) is not yet complete.

Tschoun commented 7 months ago

Something went wrong. It correctly checks, if the tiles are complete. But even when they are complete, it generates an entry into the step0_empty_asset.csv image image