search

switchbrew / nx-hbmenu

The Nintendo Switch Homebrew Menu
ISC License
1.19k stars 127 forks source link

Does not show icon.jpg on sideloaded .nro #123

Closed iUltimateLP closed 4 years ago

iUltimateLP commented 4 years ago

Hey, when developing a homebrew app I recognized that the icon.jpg is not shown in the hbmenu (and instead a switch with an exclamation mark) when transferring it either via nxlink or placing the .nro on the SD card? Is that a bug or a mistake from my side? I do have a icon.jpg placed next to the makefile and also set the path in the makefile.

Thanks!

yellows8 commented 4 years ago

https://github.com/switchbrew/nx-hbmenu#credits This library doesn't ...

iUltimateLP commented 4 years ago

Hmm it's a totally normal .jpg I saved in Photoshop, and since when was JPG ever lossless? Strange...

yellows8 commented 4 years ago

aka "progressive"

iUltimateLP commented 4 years ago

Turned it off, still the same issue. Here's the .jpg I use, if that helps. icon2

yellows8 commented 4 years ago

It needs to be 256x256 https://github.com/switchbrew/nx-hbmenu/blob/master/icon.jpg

iUltimateLP commented 4 years ago

Thanks, that was it 👍

yellows8 commented 4 years ago

Btw using fsInitialize/fsExit from an app is not needed, it's done automatically...(see fs/ examples)

Isn't capsaLoadAlbumFile/{caps*} usable for your use-case, instead of manually accessing Bis?

iUltimateLP commented 4 years ago

Thanks for the tip.

It would be usable, but there is no real advantage in copying over the data from capsaLoadAlbumFile into a buffer and then send it along the socket if the files are present (other than it might be more performant than finding the filenames right now since I haven't figured the game ID encryption in the screenshot filename out yet).

yellows8 commented 4 years ago

caps* is the proper way to access it though, and you're already using capsa anyway...