search

swongts / pe

0 stars 0 forks source link

Loop condition naming #25

Open swongts opened 3 years ago

swongts commented 3 years ago

image.png

"While mealplan exists in database" doesn't seem like a very valid condition, should it be "until mealplans have finished iterating"?

soc-se-bot commented 3 years ago

Team's Response

I am not clear by what you meant by "doesn't seem like a very valid condition" even though I agree that your phrasing also works. To me, the condition clearly means that the loop will continue iterating as long as the MealPlan object exists inside the database. This is also a form of iteration.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: "While mealplan exists in database" makes it seem like the loop will only end when all the meal plans are deleted from the database (and there are no longer any meal plans that exist in the database).