search

swook / EVE

Towards End-to-end Video-based Eye-tracking. ECCV 2020. https://ait.ethz.ch/eve
MIT License
115 stars 22 forks source link

Fix import package and function definition errors #1

Closed dongfeicui closed 2 years ago

dongfeicui commented 3 years ago

Errors in relative path of importting package

swook commented 3 years ago

Hello, thanks for creating this PR to address the issues you saw.

However, I do not think that most of the changes are necessary. If you run python train.py from the src/ directory as written in the README file, you will find that the current working directory is added to the PYTHONPATH automatically and thus it is not necessary to define relative imports.

Should you wish to call EVE methods from a different location, it is up to you to add the src/ folder to your PYTHONPATH. I do not intend to convert this code-base into a Python package.

Please do let me know if I understood your intentions incorrectly. Thanks.

dongfeicui commented 3 years ago

Hello, thanks for your reply and I get you. However, I think there are two problems in /src/core/config_default def __get_config_file_contents() and __get_python_file_contents(). Should I add first parameter “self”？

swook commented 3 years ago

Hi @Vincen-31 , so sorry about not getting back to you earlier. If you would not mind updating this PR to include just those two changes, I'd be happy to merge it in.

Otherwise, we can close this PR and I can make those fixes separately - as you wish.

Thanks

dongfeicui commented 3 years ago

Hi! @swook I don't mind updating this PR and thanks for your reply.

swook commented 3 years ago

Okay cool! I'll be waiting on the changes then, thanks a lot.