Allow flag-based control of block falling direction via InvertFallingDirFlag field on FallingComponent

swoolcock / GravityHelper

A Celeste helper mod for controlling gravity

2 stars 3 forks source link

Allow flag-based control of block falling direction via InvertFallingDirFlag field on FallingComponent #86

Closed aonkeeper4 closed 2 months ago

aonkeeper4 commented 2 months ago

Also adds a property to Gravity Dream Blocks and Inversion Blocks to support this

swoolcock commented 2 months ago

Looks okay, but I'll probably go through and move some things around for optimisation, etc.

Also ahhhhhhhhhh all the whitespace reformatting!

swoolcock commented 2 months ago

@aonkeeper4 Can you please check that this still does what you want it to? The changes I made were:

Just use a single checking function rather than a wrapper property; I'd rather not have the set and get be out of sync if possible.
Cache the return of the check where possible (if it's guaranteed to be the same frame).
Reverted the Lua formatting; I'm going to do a full pass over the project at some point so it'll probably be its own branch.

aonkeeper4 commented 2 months ago

yeah this all seems to still be working as expected, thanks for taking a look! also sorry about all the lua reformatting and me taking a while to respond, i don't really check github notifications