swoole / library

📚 Swoole Library
https://wiki.swoole.com/#/library
Apache License 2.0
242 stars 57 forks source link

Removing old PHP versions from CI's style check step #144

Closed leocavalcante closed 2 years ago

leocavalcante commented 2 years ago

phplint was removed from jakzal/phpqa:php7.3 https://github.com/jakzal/toolbox/pull/398

This PR also drops 7.2 support as well.

Fixes CI error:

/entrypoint.sh: 6: exec: phplint: not found
Error: Process completed with exit code 127.

This PR will neve be green because of #143

deminy commented 2 years ago

Added a new commit to fix syntax check under PHP 7.3.

References:

deminy commented 2 years ago

@leocavalcante Could you please check my last commit and let me know if there are any concerns? Thanks

leocavalcante commented 2 years ago

Thanks @deminy ! Way better solution than just dropping it's support.