Closed DevZer0x00 closed 9 months ago
@deminy
I added a test.
If you don't mind, I can take the exception to the ConnectionPool
The PR has been merged.
I made a change by returning a value of false when failed to get a PDO connection from the pool. This is to make the behavior of the ConnectionPool::get()
methods consistent across pools of different connection objects (PDO, mysqli, etc).
For method ConnectionPool::get()
, returning a value of false means that the pool is at full capacity, yet all connections are currently in use.
Please feel free to let me know any questions. Thanks @DevZer0x00
@DevZer0x00 Thanks for submitting the PR. Could you please let me know how you noticed the issue? Is there a way to (easily) reproduce it? I'm asking these because of two reasons:
ConnectionPool::get()
fails, people could make a retry by calling the same method again. I'm wondering if there is any better way to deal with this type of failures.