search

swoole / library

📚 Swoole Library
https://wiki.swoole.com/#/library
Apache License 2.0
237 stars 58 forks source link

Fix Content-Type override on post #73

Closed sy-records closed 3 years ago

sy-records commented 3 years ago

fix https://github.com/swoole/swoole-src/issues/3850

filakhtov commented 3 years ago

Hey @sy-records thanks for such quick PR 🙇‍♂️ I am wondering however, wouldn't it be better to lower-case the header names as we receive them? Such as here: https://github.com/swoole/library/blob/38d21c3b8a37539a48e4944019b827f2f1464010/src/core/Curl/Handler.php#L478, here https://github.com/swoole/library/blob/38d21c3b8a37539a48e4944019b827f2f1464010/src/core/Curl/Handler.php#L487 and other places?

sy-records commented 3 years ago

Okay, I'll discuss it with other members.

Please wait, this may not be optimum solution