search

swoole / swoole-src

🚀 Coroutine-based concurrency library for PHP
https://www.swoole.com
Apache License 2.0
18.47k stars 3.16k forks source link

[6.0.0beta] broken build with 8.4.0RC #5536

Closed remicollet closed 1 month ago

remicollet commented 1 month ago

ext/pdo_pgsql/pgsql_sql_parser.re:22:10: fatal error: ext/pdo/php_pdo_int.h: No such file or directory

remicollet commented 1 month ago

In https://github.com/swoole/swoole-src/blob/v6.0.0-beta/thirdparty/php84/pdo_pgsql/pgsql_sql_parser.c#L24

But this file is not installed https://github.com/php/php-src/blob/PHP-8.4/ext/pdo/config.m4#L15

remicollet commented 1 month ago

Could be fixed in RC3 with https://github.com/php/php-src/commit/a57ce052cd827357447d7ff78b12cb664663c603

Will try later when released.

remicollet commented 1 month ago

From my understanding, It may have work with some old beta thanks to https://github.com/php/php-src/commit/ad7d1a7be44419640ae08f083188f7247710ac6d

but it is broken with RC1 and later because of https://github.com/php/php-src/commit/a57ce052cd827357447d7ff78b12cb664663c603

So the content of thirdparty/php84 have to be refreshed to be synced with upstream