search

swoole / yasd

Yet Another Swoole Debugger
https://huanghantao.github.io/yasd-wiki/
Apache License 2.0
357 stars 35 forks source link

Fix php version 8.1 build. #161

Closed haad closed 2 years ago

haad commented 2 years ago

Don't access zend_file_handle internals directly, use abstraction: zend_stream_init_filename to properly initialize it.

dmitryuk commented 2 years ago

@haad What do you think to add support of php 8.1 to github action? Like reverted commit https://github.com/swoole/yasd/commit/a5f4045f63bdbe20d4f29f8720c851c38d54cc66

huanghantao commented 2 years ago

Thank you!

dmitryuk commented 2 years ago

@huanghantao looks like build failed https://github.com/swoole/yasd/runs/5283992943?check_suite_focus=true

huanghantao commented 2 years ago

@huanghantao looks like build failed https://github.com/swoole/yasd/runs/5283992943?check_suite_focus=true

Yes, may need to be compatible with it

huanghantao commented 2 years ago

@huanghantao looks like build failed https://github.com/swoole/yasd/runs/5283992943?check_suite_focus=true

Fix in #164