search

swooletw / laravel-swoole

High performance HTTP server based on Swoole. Speed up your Laravel or Lumen applications.
MIT License
4.04k stars 390 forks source link

PHP 8.0 Support? #454

Closed jiangjiangdev closed 3 years ago

jiangjiangdev commented 3 years ago

I have updated PHP to version 8.0 so... you know

Arkanius commented 3 years ago

Hi @jiangjiang0228 !

I'm looking foward to it! Unfortunatelly, I hadn't enough time to test PHP 8 with this package yet, but we have a branch with php8 support. Do you want to help us test it? :)

jiangjiangdev commented 3 years ago

@Arkanius Thx! Im using the branch

Arkanius commented 3 years ago

Nice! Please, let us know if your app is working properly as it was with the early versions of php

slava-vishnyakov commented 3 years ago

Thanks! Just in case anyone is Googling this:

composer require swooletw/laravel-swoole:dev-improvement/php8 seems to work

kocoten1992 commented 3 years ago

Anyone get into any issue ? I've using for a while, didn't got any trouble, just want to let you know!

Arkanius commented 3 years ago

@kocoten1992 nice to hear that!

amcsi commented 3 years ago

I can confirm that the php8 branch has been working for me fine for a few weeks. It's a personal project though where the website isn't visited often.

Arkanius commented 3 years ago

Nice to hear that. So, I think that in a couple weeks it's a good time to release the support to php8

amcsi commented 3 years ago

I still haven't had any problems with the php8 branch in my small, personal project.

Arkanius commented 3 years ago

Nice job. are you using websockets or your app is request based?

amcsi commented 3 years ago

@Arkanius request-based. No websockets.

It's open source by the way: https://github.com/amcsi/lycee-overture

Arkanius commented 3 years ago

Applied as https://github.com/swooletw/laravel-swoole/releases/tag/v2.8.0

Thanks everyone!