Websocket - Sandbox missing for disconnect event

swooletw / laravel-swoole

High performance HTTP server based on Swoole. Speed up your Laravel or Lumen applications.

MIT License

4.04k stars 390 forks source link

Websocket - Sandbox missing for disconnect event #499

Closed netdown closed 3 years ago

netdown commented 3 years ago

Sandbox must be created even when disconnect event is dispatched, because for example the providers are not set otherwise. In my specific case, I would like to log the disconnection of the user, but authentication guards do not work without this.

Arkanius commented 3 years ago

Please, follow the issue guideline

netdown commented 3 years ago

@Arkanius There is no issue template when creating pull requests. What would you like me to elaborate on? It seems pretty clear to me, especially that this is a few-liner (but essential).

Arkanius commented 3 years ago

Oh, sorry @netdown ! I misread it (apparently I confused with another PR) and I thougth you were referencing an issue without guideline, my bad :sweat_smile:

Your PR is fine, I'll merge it and it will be present on the next release, thanks!