search

swooletw / laravel-swoole

High performance HTTP server based on Swoole. Speed up your Laravel or Lumen applications.
MIT License
4.04k stars 390 forks source link

Added openswoole extension check compatibility #506

Closed nahid closed 2 years ago

nahid commented 2 years ago

Swoole now became openswoole, from version 4.7.2 swoole extension changed as openswoole. For this reason, this package can not detect the extension and shows the message Can't detect Swoole extension installed. This commit fixed the issue.

Arkanius commented 2 years ago

Thanks for your contribution! Sorry, I was on vacation and couldn't see this before.

I've just one doubt, please check my review

nahid commented 2 years ago

@Arkanius please check the review

Arkanius commented 2 years ago

Got it! You're right! we'll apply your PR!

Thanks for contributing!

ErriourMe commented 2 years ago

When it will be released? (:

madhurbhaiya commented 2 years ago

Hi @Arkanius

Please release this minor change. Otherwise, we need to Extend the Command and Service Provider in our code, just to get OpenSwoole working with Laravel

Arkanius commented 2 years ago

@madhurbhaiya @ErriourRU sorry by my late response here guys, I had some problems and was really busy, I'm sorry again =/

Well, it's merged, but please, test it out and check if your apps is running well. I'll be wating your answer