search

swoops / eval_villain

A Firefox Web Extension to improve the discovery of DOM XSS.
GNU General Public License v3.0
249 stars 35 forks source link

Fix spelling #3

Closed xunoaib closed 2 years ago

xunoaib commented 2 years ago

Fixes a few typos and grammar

swoops commented 2 years ago

Thank you @xunoaib! Sorry I missed it. Thanks @TechStudent11 for causing a ping that I did catch.

All looks good for this.

There is a small bug but that is something I have to live with I think. Changing the config schema (ie fixing "patern") means the old config wont work anymore. So anyone upgrading EV will have EV silently fail when the new spelling does not find anything in storage. I will address this in another pull though, unless you want to try and tackle it.

TechStudent10 commented 2 years ago

Thank you @xunoaib! Sorry I missed it. Thanks @TechStudent11 for causing a ping that I did catch.

No problem :). I didn't know that approving causes a ping.

Also, don't just thank me, thank @PwnFunction for starring this repo. If he didn't do that, I wouldn't have approved this PR.

swoops commented 2 years ago

No problem :). I didn't know that approving causes a ping.

I didn't know you could review the code :) I appreciate the help.

TechStudent10 commented 2 years ago

Once again, no prob.

Edit: @PwnFunction thanks for the reaction. Appreciate it.