search

swoops / eval_villain

A Firefox Web Extension to improve the discovery of DOM XSS.
GNU General Public License v3.0
249 stars 35 forks source link

Cannot load add-on via Selenium #5

Closed psiinon closed 1 year ago

psiinon commented 1 year ago

Hiya 😁 We've had a bug complaining that Eval Villain is no longer loaded when ZAP launches Firefox: https://github.com/zaproxy/zaproxy/issues/7878

Thanks to @willdurand we've found out its a bug in Selenium, which we're following up on.

But there is a work around: "it looks like the source manifest.json doesn't include browser_specific_settings, which means AMO sets it (yes, AMO slightly updates manifest.json files these days). I think the workaround is to update the manifest.json file and add applications.gecko.id, and then get that new version signed by AMO."

You ok doing this until selenium gets fixed?

swoops commented 1 year ago

Yeah, I can try to do that.

I removed those settings because AMO complained about them during the last release.. I should have a new version pushed in a couple hours. I think I am going to read up on it just a bit.

thc202 commented 1 year ago

It's no longer necessary to do that, we are now able to install the current version. Thank you!

I think this can be closed now.

swoops commented 1 year ago

Cool, thanks for the heads up.