search

swordev / suid

A port of Material-UI (MUI) built with SolidJS.
https://suid.io
MIT License
682 stars 49 forks source link

Add `LoadingButton` support #255

Open BierDav opened 1 year ago

BierDav commented 1 year ago

I've added another package @suid/lab, even though i've fixed the known issues on mui it's unstable too, so I tried to match that. Maybe this requires also an update of codemod when using react2solid, but i don't have an idea what and where to change so i hope for a follow up commit after merging that updates that.

Documentation is also added for the new component. I've already tested the component with ssr, so it should also work with ssr.

This PR includes my other PR, because i needed everything in one branch so that i cloud start using my code locally.

BierDav commented 1 year ago

Please merge

BierDav commented 1 year ago

@juanrgm Please

BierDav commented 1 year ago

Hello?

juanrgm commented 1 year ago

I greatly appreciate the work you've done, but I'm reluctant to incorporate experimental packages into the project or ones outside of @mui/material.

SUID requires constant effort and incorporating experimental packages can hinder the evolution of the project.

I know that the component is simple and surely there will be no problem, but going outside of @mui/material opens the door for other users to request more components from @mui/lab, @mui/joy and @mui /x-* and would mean a total overflow of work, something that no project maintainer could assume.

I hope you understand and share my position, in any case I am open to suggestions.

BierDav commented 1 year ago

Hmmm, i see your point. But what if we just make clear that @mui/lab is not officially maintained? I would love to see a compromise, because as a developer, I just want to use the library and don't always have to worry about missing features. And i think there are a lot of people who would love to use this component. The problem is really that we need it to be in a npm package. And the last thing i want to do is creating my own fork and publishing it to confuse all other people.