search

swordlegend / recastnavigation

Automatically exported from code.google.com/p/recastnavigation
zlib License
0 stars 0 forks source link

[Enhancement] Remove areaID check in rcMarkConvexPolyArea #121

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The check:
if (areaId < chf.areas[i])
in rcMarkConvexPolyArea does not make sense. This is not a way to safely 
compare two of these IDs to each other. Instead, the user should pass 
overlapping markings in the correct order; for instance, I mark all my 
automatic generated polygons before i mark my manual ones. This way, if a 
manual polygon and an automatic polygon overlap, the manual one will still 
'win'.

Original issue reported on code.google.com by DanteDr...@gmail.com on 1 Sep 2010 at 6:37

GoogleCodeExporter commented 9 years ago 
Oops - wrong email. Anyways, this is my real email. :)
What is this check for anyway?

Original comment by Jakob.Bo...@gmail.com on 1 Sep 2010 at 6:43

GoogleCodeExporter commented 9 years ago 
I have to check. At some point there was more code which was using the area 
codes as priorities. It made certain types of operations possible.

Original comment by memono...@gmail.com on 1 Sep 2010 at 6:50

GoogleCodeExporter commented 9 years ago 
That priority stuff was indeed some old idea I had long time ago. I removed it 
and also the one from the box code too. Changed in R219.

Original comment by memono...@gmail.com on 17 Sep 2010 at 7:30