RecastMeshDetail.cpp: getHeightData: tmpData argument never used.

[GoogleCodeExporter]

This issue does not impact functionality.  It only results in some
temporary unneeded memory consumption.

Validated to exist in SVN as of this date. (Revision 71)

File: RecastMeshDetail.cpp
Operation: getHeightData
Argument: tmpData

The tmpData argument is not >>currently<< used anywhere in the code block
of the operation, though it does appear in code that remains commented out.

tmpData first appears in revision 64 (10/23/2009) with use only in
commented out code.  The code which uses tmpData has remained commented out
through revision 71.  

Possibility: Code and argument staged for later use?

If tmpData is removed as an argument, then the following local variable can
also be removed:

File: RecastMeshDetail.cpp
Operation: rcBuildPolyMeshDetail
Local Variable: tmpData (Same name as argument.)

(Mikko: If you don't want me to submit these kinds of low impact issues,
just let me know.  Right now I'm operating on a better safe than sorry
paradigm.)

Original issue reported on code.google.com by steve...@gmail.com on 20 Nov 2009 at 10:23

[GoogleCodeExporter]

Keep 'em coming :) I don't mind fixing them. That particular piece of code was
something that fixed few cases, but I was not quite sure if I want to keep. I'll
remove it.

Original comment by memono...@gmail.com on 21 Nov 2009 at 7:02

• Changed state: Accepted

[GoogleCodeExporter]

Unused var and commented out code removed in rev 75.

Original comment by memono...@gmail.com on 23 Nov 2009 at 8:35

• Changed state: Fixed