search

swp-fu-eid / eid-fu-swp

Docker-based REST API implemented with Django and restframework.
MIT License
2 stars 1 forks source link

Windows fix #2

Closed BenjaminKeller closed 7 years ago

BenjaminKeller commented 7 years ago

This branch contains fixes for running the example on Windows. See #1 for more information. All members which are forced to use Windows should review this.

BenjaminKeller commented 7 years ago

At now there exist two docker compose files docker-compose.yml and docker-compose.logging.yml. Looking at the file names the intention is not clear. I think we have to improve on that.

1. Solution: Renaming

docker-compose.yml -> docker-compose.syslogd.yml docker-compose.logging -> docker-compose.default.yml

2. Solution: Switch to default logging

Is there any reason we want to log with syslogd? I am not a docker specialist.

3. Solution: Remain

If there is a good reason for logging with syslogd we should appreciate that and get to used by it.

Result

I think the first solution is the best as it forces you to choose one and rename it.