search

swp-fu-eid / eid-fu-swp

Docker-based REST API implemented with Django and restframework.
MIT License
2 stars 1 forks source link

Adjust open id provider login #48

Closed larissazech closed 7 years ago

larissazech commented 7 years ago

Use example client to test the whole flow and decrypt the id_token containing the chosen username.

Since this branch was forked from add_open_id_provider, it might be necessary to merge PR #41 first and to rebase this one on master afterwards.

corresponding issue: #34

nils-wisiol commented 7 years ago

(I changed the PR base to make an 'early' review possible. This should nevertheless be merged to master, not into add_open_id_provider.)

larissazech commented 7 years ago

Committed minor code style changes. Still missing: e2e tests. Regarding issue #62, we propose to make massive changes on this code base. Therefore, the pull request has to wait until those changes are done and e2e tests are implemented.

nils-wisiol commented 7 years ago

is this currently waiting for review?

BenjaminKeller commented 7 years ago

No, we have to made changes according to #62. Then, we will call for review.

auvin commented 7 years ago

Referring to #41, this is closed.