search

swp-fu-eid / eid-fu-swp

Docker-based REST API implemented with Django and restframework.
MIT License
2 stars 1 forks source link

Changed testing framework to chakram #56

Closed Armagetron closed 7 years ago

BenjaminKeller commented 7 years ago

@Armagetron I have a pr coming with more frisby-jasmine tests. I would propose to merge my pr first and change the tests after that.

Armagetron commented 7 years ago

I have some conflicts in this commit. This PR is not yet ready

nils-wisiol commented 7 years ago

I requested some more tests in #57, so it may be worth to prioritize the migration to chakram and then rebase #57 on top of it. You decide.

BenjaminKeller commented 7 years ago

OK, I think we go for migration first then. @Armagetron I can rewrite the tests. Have you pushed all your work?

BenjaminKeller commented 7 years ago

@nils-wisiol Tests are now adapted to chakram. Please merge.

BenjaminKeller commented 7 years ago

@nils-wisiol Please merge. I need it for #57.

Armagetron commented 7 years ago

Can we have this merged? After that we can update the other branches

nils-wisiol commented 7 years ago

Failing tests show as green in travis. (based on b441d48bb50280561cd4b509f333d0a09cef0ffd)

BenjaminKeller commented 7 years ago

@nils-wisiol Indentation is fixed. Tests are not failing anymore. @Armagetron Can you have a look at travis?

nils-wisiol commented 7 years ago

Failing tests are still green.

nils-wisiol commented 7 years ago

I backported chakram to boilerplate, including 'red on fail' travis tests. I guess you could just take the exit code determination from there.

BenjaminKeller commented 7 years ago

Travis fails now for failing tests: click

@nils-wisiol Done.