Add eid types for the eid server

m273d15 commented 7 years ago

This PR (for issue #51 ) replaces #65 .

Replaced assert by assertEqual
Replaced try catch by assertRaises
Added blank lines as defined in PEP8
Added newline if line is longer than 120 characters
Sorted commits by types
Moved all types and tests from the directory boilerplate to eid_server Created by @m273d15 and @larissazech

larissazech commented 7 years ago

@nils-wisiol, @m273d15 and I fixed the indentation and the regex and rebased to master. Can we merge?

larissazech commented 7 years ago

Taken from the eID Server specification:

The type SessionType SHALL be used to uniquely identify a request to the eID-Interface. The eID-Server MUST generate values for the ID element to identify different requests for Online-Authentication. The value of the element ID MUST be random and at least 32 characters long in hexadecimal representation so that it's not easy to guess. The software component generating the random numbers used as IDs SHALL fulfill the requirements described in [TR-03116-4] Section 6.2: Zufallszahlen and the eID-Service MUST ensure that no active sessions using identical IDs exist in the same context.The eService SHALL only use valid session IDs for calls of the function getResult.

I would suggest to leave the generation of a random number to the component instantiating a SessionType and to only check for the 16Bits HexBinary (as described in the xsd) here.

@m273d15 @Armagetron Agreed?

larissazech commented 7 years ago

We discussed the SessionID-issue internally and agreed upon the suggested solution. Commit history has been cleaned. Can we merge?

nils-wisiol commented 7 years ago

Let's merge this once we need it

swp-fu-eid / eid-fu-swp

Add eid types for the eid server #70