AST- LoopNode and ArrayIdentifierNode invalid design

swp-uebersetzerbau-ss13 / common

Shared files between teams.

1 stars 0 forks source link

Closed Tkrauss closed 11 years ago

Tkrauss commented 11 years ago

Body of loop can be a single assignment, not just a blocknode
similar to fixed BranchNode (93e7fc447ac48d7b58940d9e127154d33f54edf6)
ArrayIdentifierNode
_public void setIndex(Integer index);_ and _public Integer getIndex();_
functions signature yields a constant index
implications of that design should be obvious
i propose to use a ExpressionNode instead
- _public void setIndexNode(ExpressionNode indexNode);_
- _public ExpressionNode getIndexNode();_

fub-frank commented 11 years ago

ack ^^

leinge commented 11 years ago

Dito ;-)

leinge commented 11 years ago

Pushed suggested changes to branch "ast-changes-ms3". I will merge them Monday 20:00 if there are no more concerns!