search

swri-robotics / gps_umd

BSD 3-Clause "New" or "Revised" License
86 stars 94 forks source link

Fix uninitialized parameter exception in gpsd_client #83

Closed erikboto closed 1 year ago

erikboto commented 1 year ago

When trying to run the constructor throws an exception: "Component constructor threw an exception: Statically typed parameter 'use_gps_time' must be initialized."

This problem is described here: https://github.com/ros2/rclcpp/issues/1691

Solve this by using the non-template way of declaring the parameters.

danthony06 commented 1 year ago

Looks good, thanks for the fix. I'll try to get this released for Humble, Iron, and Rolling.

danthony06 commented 1 year ago

Okay, I've bloomed releases with this fix for Humble, Iron, and Rolling. It should be available whenever v2.0.3 of this package gets through the build farm.