swri-robotics / mapviz

Modular ROS visualization tool for 2D data.
BSD 3-Clause "New" or "Revised" License
370 stars 144 forks source link

Release binaries for ROS 2? #784

Closed SteveMacenski closed 10 months ago

SteveMacenski commented 10 months ago

There is some discussion about using this w.r.t. a tutorial in Nav2 for GPS waypoint following. A blocker for that is that this isn't released in binary format - is there a reason for that and/or is this something that can be released?

Thanks! S

danthony06 commented 10 months ago

Let me figure it out. I'm happy to make changes or add features to support Nav2 integration, so please let me know if there's anything else we can do as well.

danthony06 commented 10 months ago

@SteveMacenski I've got the process rolling. The binary releases were disabled a while ago due to a dependency issue. I resolved that issue a few months ago, but the builds never got unblocked. I've updated the issue to draw attention to it, and hopefully everything gets rapidly released now: https://github.com/ros2-gbp/mapviz-release/issues/2.

SteveMacenski commented 10 months ago

Awesome! This sounds like a way to go then!

danthony06 commented 10 months ago

@SteveMacenski it should be unblocked on the buildfarm and available as soon as that process completes.

SteveMacenski commented 10 months ago

Great, thanks! For which distributions?

danthony06 commented 10 months ago

Humble and Iron. If there's a need for Rolling, I can do that as well.

SteveMacenski commented 10 months ago

Rolling as well would be great since alot of our users are on rolling to get the bleeding edge of Nav2

danthony06 commented 10 months ago

Alright, it's been a while since I've tried on Rolling. I'll try to get all of the dependencies and the package released tonight.

danthony06 commented 10 months ago

Okay, I have it building locally on Rolling and am working on blooming it. Several of the dependencies we maintain haven't been bloomed either, so that's also getting updated.

danthony06 commented 10 months ago

I'm also going to make a big push to get this working on Arm devices. It's been a common request, and I think I know what we need to do to get it going.

SteveMacenski commented 10 months ago

What deps are missing?

danthony06 commented 10 months ago

marti_common and marti_messages, which are things we maintain. I had pretty old versions in Rolling, and I just bloomed new versions of them.

On Tue, Aug 22, 2023, 3:11 PM Steve Macenski @.***> wrote:

What deps are missing?

— Reply to this email directly, view it on GitHub https://github.com/swri-robotics/mapviz/issues/784#issuecomment-1688857702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBZWHDTUENDOQBZIPD3WUTXWUG73ANCNFSM6AAAAAA3V5CKC4 . You are receiving this because you commented.Message ID: @.***>

danthony06 commented 10 months ago

Okay, I just bloomed Mapviz for rolling. The PR request is here: https://github.com/ros/rosdistro/pull/38343.

SteveMacenski commented 10 months ago

Thanks! Tutorial coming soon!

jonselling commented 9 months ago

It looks like on 22.04 I only see apt packages for mapviz-interfaces and not the binary release of mapviz (on humble, iron, or rolling).

Does the swri_roscpp builds need to be enabled again? (I believe this is the rolling build?)

danthony06 commented 9 months ago

marti_common wasn't building correctly, which was blocking Mapviz. I just released v3.6.1 of marti_common to the buildfarm, and it looks like it's building, which should unblock Mapviz on x86 platforms. I already got marti_common packages unblacklisted on the buildfarm, so everything should be good now.

On Fri, Sep 8, 2023, 10:52 AM Jonathan Selling @.***> wrote:

It looks like on 22.04 I only see apt packages for mapviz-interfaces and not the binary release of mapviz (on humble, iron, or rolling).

Does the swri_roscpp builds need to be enabled again? (I believe this is the rolling build https://build.ros2.org/job/Rbin_uJ64__swri_roscpp__ubuntu_jammy_amd64__binary/ ?)

— Reply to this email directly, view it on GitHub https://github.com/swri-robotics/mapviz/issues/784#issuecomment-1711879825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBZWHHRZNMXQIKTFI5RFY3XZM5MTANCNFSM6AAAAAA3V5CKC4 . You are receiving this because you modified the open/close state.Message ID: @.***>